magento/magento2#: Replace deprecated methods in back-end controllers of Magento/Customer #24285

atwixfirster · 2019-08-25T11:33:26Z

Description (*)

Pull request replaces deprecated addError, addSuccess, addException methods

addError -> addErrorMessage
addSuccess -> addSuccessMessage
addException -> addExceptionMessage

in the next controllers:

app/code/Magento/Customer/Controller/Adminhtml/Index/MassAssignGroup.php
app/code/Magento/Customer/Controller/Adminhtml/Index/MassDelete.php
app/code/Magento/Customer/Controller/Adminhtml/Index/MassSubscribe.php
app/code/Magento/Customer/Controller/Adminhtml/Index/ResetPassword.php
app/code/Magento/Customer/Controller/Adminhtml/Index/Save.php
app/code/Magento/Customer/Controller/Adminhtml/Index.php
app/code/Magento/Customer/Controller/Adminhtml/Locks/Unlock.php

Fixed Issues (if relevant)

magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Thank you!

m2-assistant · 2019-08-25T11:33:28Z

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

dmytro-ch

@atwixfirster could yo please check the failing unit tests?

ihor-sviziev

Hi @atwixfirster,
Could you review and fix integration tests?

ihor-sviziev · 2019-08-28T06:24:34Z

@magento run all tests

atwixfirster · 2019-08-28T08:40:01Z

Could you review and fix integration tests?

@dmytro-ch @ihor-sviziev,

done

Thanks, guys!

magento-engcom-team · 2019-08-28T08:43:39Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5723 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Alfa · 2019-08-29T09:03:40Z

Hi @atwixfirster

During testing we faced the issue

Problem: "404 Error" message occurs when trying to "Subscribe to Newsletter" via mass action

Manual testing scenario:

Login to Admin;
Create 2 customers for example;
Select them from the grid;
Select "Subscribe to Newsletter" from drop down menu;

Actual Result:

@atwixfirster Could you take a look, please?

Thanks!

atwixfirster · 2019-08-29T09:06:22Z

Thank you, @engcom-Alfa !

I will check

edenduong · 2019-08-29T11:26:18Z

@dmytro-ch : Should they combine to one??

#24284
#24197
#24340

dmytro-ch · 2019-08-29T11:43:57Z

@edenduong, these PRs will be combined after approval.
Thank you!

ihor-sviziev · 2019-08-29T12:24:17Z

@dmytro-ch : Should they combine to one??

#24284
#24197
#24340

It's really easier to test each PR separately

dmytro-ch · 2019-08-29T14:03:27Z

It's really easier to test each PR separately

I agree, it depends on PRs.

magento-engcom-team · 2019-08-29T14:57:33Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5723 has been created to process this Pull Request

sidolov

@atwixfirster please, take a look at the issue reported by @engcom-Alfa

atwixfirster · 2019-08-29T16:48:00Z

@atwixfirster please, take a look at the issue reported by @engcom-Alfa

@sidolov, of course . I will check that issue in 3-4 hours.

Thanks

atwixfirster · 2019-08-29T21:39:27Z

@atwixfirster please, take a look at the issue reported by @engcom-Alfa

fixed

Thank you, @engcom-Alfa 👍

ihor-sviziev

Hi @atwixfirster,
Unfortunately integration tests started failing after your latest change.
Please review & fix them.
Thank you!

… of Magento/Customer - app/code/Magento/Customer/Controller/Adminhtml/Index/MassAssignGroup.php - app/code/Magento/Customer/Controller/Adminhtml/Index/MassDelete.php - app/code/Magento/Customer/Controller/Adminhtml/Index/MassSubscribe.php - app/code/Magento/Customer/Controller/Adminhtml/Index/ResetPassword.php - app/code/Magento/Customer/Controller/Adminhtml/Index/Save.php - app/code/Magento/Customer/Controller/Adminhtml/Index.php - app/code/Magento/Customer/Controller/Adminhtml/Locks/Unlock.php

atwixfirster · 2019-08-30T04:51:15Z

Hi @atwixfirster,
Unfortunately integration tests started failing after your latest change.
Please review & fix them.
Thank you!

Good morning, @ihor-sviziev!

fixed

magento-engcom-team · 2019-08-31T07:43:32Z

Hi @dmytro-ch, thank you for the review.
ENGCOM-5723 has been created to process this Pull Request

engcom-Alfa · 2019-09-02T09:37:11Z

✔️ QA Passed

…d controllers of Magento/Customer #24285

m2-assistant · 2019-09-02T19:12:09Z

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team added Component: Customer Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 25, 2019

dmytro-ch self-requested a review August 26, 2019 06:15

dmytro-ch self-assigned this Aug 26, 2019

dmytro-ch requested changes Aug 26, 2019

View reviewed changes

ghost added the Progress: needs update label Aug 26, 2019

ihor-sviziev requested changes Aug 28, 2019

View reviewed changes

ghost assigned ihor-sviziev Aug 28, 2019

ihor-sviziev approved these changes Aug 28, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 28, 2019

ihor-sviziev added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 28, 2019

engcom-Alfa self-assigned this Aug 29, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 29, 2019

ghost added Progress: needs update and removed Progress: testing in progress labels Aug 29, 2019

dmytro-ch approved these changes Aug 29, 2019

View reviewed changes

ihor-sviziev approved these changes Aug 29, 2019

View reviewed changes

sidolov requested changes Aug 29, 2019

View reviewed changes

ghost assigned sidolov Aug 29, 2019

ghost added Progress: needs update and removed Progress: ready for testing labels Aug 29, 2019

atwixfirster force-pushed the customer-replace-deprecated-message-func-adminhtml-controllers branch from 887c9cc to d1e9194 Compare August 29, 2019 21:38

ihor-sviziev requested changes Aug 30, 2019

View reviewed changes

atwixfirster force-pushed the customer-replace-deprecated-message-func-adminhtml-controllers branch from d1e9194 to 5842160 Compare August 30, 2019 04:50

engcom-Alfa requested a review from sidolov August 30, 2019 07:22

dmytro-ch approved these changes Aug 31, 2019

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 31, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Sep 2, 2019

ghost added Progress: extended testing and removed Progress: testing in progress labels Sep 2, 2019

engcom-Foxtrot self-assigned this Sep 2, 2019

ghost added Progress: accept and removed Progress: extended testing labels Sep 2, 2019

magento-engcom-team pushed a commit that referenced this pull request Sep 2, 2019

ENGCOM-5723: magento/magento2#: Replace deprecated methods in back-en…

6de4937

…d controllers of Magento/Customer #24285

magento-engcom-team merged commit 5842160 into magento:2.3-develop Sep 2, 2019

magento-engcom-team added this to the Release: 2.3.4 milestone Sep 2, 2019

magento/magento2#: Replace deprecated methods in back-end controllers of Magento/Customer #24285

magento/magento2#: Replace deprecated methods in back-end controllers of Magento/Customer #24285

Uh oh!

Conversation

atwixfirster commented Aug 25, 2019

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Aug 25, 2019

Uh oh!

dmytro-ch left a comment

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev commented Aug 28, 2019

Uh oh!

atwixfirster commented Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magento-engcom-team commented Aug 28, 2019

Uh oh!

engcom-Alfa commented Aug 29, 2019

Uh oh!

atwixfirster commented Aug 29, 2019

Uh oh!

edenduong commented Aug 29, 2019

Uh oh!

dmytro-ch commented Aug 29, 2019

Uh oh!

ihor-sviziev commented Aug 29, 2019

Uh oh!

dmytro-ch commented Aug 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magento-engcom-team commented Aug 29, 2019

Uh oh!

sidolov left a comment

Choose a reason for hiding this comment

Uh oh!

atwixfirster commented Aug 29, 2019

Uh oh!

atwixfirster commented Aug 29, 2019

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

atwixfirster commented Aug 30, 2019

Uh oh!

magento-engcom-team commented Aug 31, 2019

Uh oh!

engcom-Alfa commented Sep 2, 2019

Uh oh!

m2-assistant bot commented Sep 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

atwixfirster commented Aug 28, 2019 •

edited

Loading

dmytro-ch commented Aug 29, 2019 •

edited

Loading